This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
fnutils and errutils test cases, inline docs, listall fnc fix #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neo7337
commented
May 20, 2023
neo7337
commented
- added test cases for fnutils
- added test cases for errutils
- added inline docs for fnutils and errutils
This was
linked to
issues
May 20, 2023
Closed
neo7337
commented
May 20, 2023
| // ExecuteAfter(nil, timeout) | ||
| //}) | ||
| // | ||
| //t.Run("Execution does not occur when timeout is negative", func(t *testing.T) { |
There was a problem hiding this comment.
@nandagopalan have a look at this condition if we need to cater for this in our logic
neo7337
commented
May 20, 2023
| // } | ||
| //}) | ||
| // | ||
| //t.Run("No execution occurs if the function is nil", func(t *testing.T) { |
There was a problem hiding this comment.
@nandagopalan same here, if we need to handle this condition in our logic
There was a problem hiding this comment.
I think we may have to put a nil check in the code.
There was a problem hiding this comment.
I am approving this PR we will add that as a separate issue.
Closed
neo7337
changed the title
nandagopalan
approved these changes
Jun 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.