-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited .separatedBy() to return a list by default. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decheverri123
changed the title
removed .separatedBy() to return a list by default.
edited .separatedBy() to return a list by default.
May 24, 2023
nank1ro
requested changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I really appreciate it. Just commented two things but it's good
nank1ro
requested changes
May 24, 2023
Just bump the lib version to 1.1.1 and update the CHANGELOG please and I merge it |
nank1ro
approved these changes
May 25, 2023
LGTM! 🚀 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.separatedBy() method kept throwing error
getting Iterable<Widget> can't be assigned to parameter type List<Widget>.
This change updated the .separatedBy() method to return a list by default so examples like this which were documented on the pub page will work.
Some tests were also added to insure functionality.
Issue link
If your PR closes an issue, use the
closes
keyword followedby its link, for example:
replacing
{ISSUE_NUMBER}
with the number, like:1
Type of Change