Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited .separatedBy() to return a list by default. #4

Merged
merged 6 commits into from
May 25, 2023

Conversation

decheverri123
Copy link
Contributor

@decheverri123 decheverri123 commented May 24, 2023

Description

.separatedBy() method kept throwing error getting Iterable<Widget> can't be assigned to parameter type List<Widget>.
This change updated the .separatedBy() method to return a list by default so examples like this which were documented on the pub page will work.

body: Center(
       child: Column(
           children: [
            Text("Hello"),
            Text("Bye"),
            Text("Ca va")
        ].separatedBy(SizedBox(height: 20)),
),

Some tests were also added to insure functionality.

Issue link

If your PR closes an issue, use the closes keyword followed
by its link, for example:

closes https://github.com/nank1ro/awesome_flutter_extensions/issues/{ISSUE_NUMBER}

replacing {ISSUE_NUMBER} with the number, like: 1

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • [ x] 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • [x ] 🧹 Code refactor
  • [x ] 📝 Documentation
  • 🗑️ Chore

@decheverri123 decheverri123 changed the title removed .separatedBy() to return a list by default. edited .separatedBy() to return a list by default. May 24, 2023
@nank1ro nank1ro self-assigned this May 24, 2023
@nank1ro nank1ro added the enhancement New feature or request label May 24, 2023
Copy link
Owner

@nank1ro nank1ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I really appreciate it. Just commented two things but it's good

test/misellaneous_ext_test.dart Outdated Show resolved Hide resolved
test/misellaneous_ext_test.dart Outdated Show resolved Hide resolved
test/misellaneous_ext_test.dart Outdated Show resolved Hide resolved
test/misellaneous_ext_test.dart Outdated Show resolved Hide resolved
@nank1ro
Copy link
Owner

nank1ro commented May 25, 2023

Just bump the lib version to 1.1.1 and update the CHANGELOG please and I merge it

@nank1ro nank1ro merged commit 695e113 into nank1ro:main May 25, 2023
@nank1ro
Copy link
Owner

nank1ro commented May 25, 2023

LGTM! 🚀 Thank you!

@decheverri123 decheverri123 deleted the separatedByFix branch May 25, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants