Add intermediary image to Frame for user graphics
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new `Frame` image acts as an intermediary buffer between the user's graphics and the swapchain image for presentation. See nannou-org#224 for more details. This is a WIP as the `draw` and `ui` graphics interop have not been updated to account for the updated `Frame` type.
This updates the `vk_triangle.rs` example for the addition of the addition of an intermediary buffer to the `Frame` type. This also adds a `vk_triangle_raw_frame.rs` example to demonstrate how to draw directly to the swapchain images as was the previous behaviour.
Creates a `ViewFramebuffer` type to make it easier to manage framebuffers' whose output image attachment is the image associated with a `Frame`. The `ViewFramebuffer` type fills a similar role to the `SwapchainFramebuffers` type but for working with the `Frame` type rather than the `RawFrame` type.
mitchmindtree
force-pushed
the
intermediate_frame_image
branch
from
62a5369
to
ba40591
Compare
|
@freesig OK I think this PR should be all ready to go now, and |
mitchmindtree
force-pushed
the
intermediate_frame_image
branch
from
940eecf
to
379fd43
Compare
mitchmindtree
changed the title
Frame for user graphicsFrame for user graphics
|
Just tested simple_ui.rs on mac and everything is running perfectly again! Also seems to have solved the timing errors we were seeing in #250 :) |
|
It's working man!!!!! |
mitchmindtree
added a commit
to mitchmindtree/nannou
that referenced
this pull request
Feb 14, 2019
This was referenced Feb 14, 2019
mitchmindtree
added a commit
that referenced
this pull request
Mar 30, 2019
mitchmindtree
added a commit
that referenced
this pull request
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new
Frameimage acts as an intermediary buffer between the user'sgraphics and the swapchain image for presentation.
See #224 for more details.
This is a WIP as the
drawanduigraphics interop have not beenupdated to account for the updated
Frametype. Many of thevk_*examples also still require updating.