Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the method dispatch to AddComands for AutoCommandBufferBuilder #396

Merged

Conversation

mft-ableton
Copy link

I am interested in rendering the output of some compute shaders to the swap chain.
I added the dispatch() method to AddCommands related to AutoCommandBufferBuilder, so that compute pipeline execution and graphics rendering can take place in the same command buffer.
I also added an example to show one use case.

I saw the comment Note that certain builder methods are *not* provided in order to avoid unexpected behaviour in raw.rs... was this one intentionally left out?

mft added 2 commits September 15, 2019 14:59
Render a fractal to an image using a compute pipeline and then render the image to the swapchain using a graphics pipeline.
The two rendering phases are put in the same command buffer.
@mitchmindtree
Copy link
Member

mitchmindtree commented Sep 19, 2019

Sorry about the delay @mft-ableton!

I think this is totally fine to add and makes a lot of sense. Thanks a lot for the new example as well!

Just a heads up, there's a good chance the vk module will change a lot (or eventually be removed) in the future in favour of a switch to rendy - see issue #374 where we've been discussing this a little. That said, I think this is super useful in the meantime, and we don't really have any estimate on time frame for that rendy work just yet anyway. Thanks! Edit: By the way, feel free to reply here or get in touch on slack if you want to hear more about the rendy plans! Would be happy to discuss it with you if you want more info or have some input!

@mitchmindtree mitchmindtree merged commit e5e577b into nannou-org:master Sep 19, 2019
@mft-ableton
Copy link
Author

Great! Thank you very much, I'm happy to contribute something that is not about a typo for once. Hehe.
I just read the the rendy issue. I have to say I am very happy with Vulkano so far but I'm still very fresh, so I'm more learning about what it can rather than what it can't.
What do you mean with slack? I was not aware I could communicate on slack with people outside of my company.

@JoshuaBatty
Copy link
Member

Hi @mft-ableton , see this link to get an invitation to our nannou slack channel. A lot of us hang out there all day and it's a fun place to ask questions and share nannou knowledge.

@mft-ableton
Copy link
Author

Ah great, I was not aware of it. I just registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants