Bound depth of hinted scheduler block traversal #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
previously approved these changes
Jan 15, 2024
clemahieu
approved these changes
Jan 15, 2024
I'll add configuration in another PR since it looks like schedulers config needs to be a bit better organized |
clemahieu
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Bound depth of hinted scheduler block traversal * Return early when stopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the depth of the hinted scheduler block traversal to a maximum of 64 iterations, which should be enough for live network activity where cemented block differences are small. This prevents potential infinite loops.