Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for node.fork_publish_inactive #4382

Merged

Conversation

dsiganos
Copy link
Contributor

By taking a copy of blocks and saving it into a variable we are not giving a chance to the ASSET_TIMELY to work if the result is not immediately correct.

By taking a copy of blocks and saving it into a variable we are not giving
a chance to the ASSET_TIMELY to work if the result is not immediately
correct.
@dsiganos dsiganos added unit test Related to a new, changed or fixed unit test exclude from changelog Indicates the change is not relevant for appearing in the release changelog labels Jan 21, 2024
pwojcikdev
pwojcikdev previously approved these changes Jan 21, 2024
Copy link
Contributor

@pwojcikdev pwojcikdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASSERT_NE (election->blocks ().end (), election->blocks ().find (send1->hash ()));
I don't think ASSERT_NE is a good choice for comparing iterators

clemahieu
clemahieu previously approved these changes Jan 21, 2024
@dsiganos dsiganos merged commit 815ac36 into nanocurrency:develop Jan 22, 2024
18 of 19 checks passed
@dsiganos dsiganos deleted the fix_node_fork_publish_inactive branch January 22, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog Indicates the change is not relevant for appearing in the release changelog unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants