Fix failing TEST (active_transactions, fifo) #4394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase manually pushes two blocks to the election scheduler.
However the backlog population sometimes also pushes the block to the election scheduler resulting in it being dropped twice.
--> The solution is to disable the backlog population for this testcase
After this change I ran the testcase 100k times and saw it failing only once. (Compared to ~1 in 1000 before)
The
stats
indicate that an election can still get activated by priority scheduler:type: election_scheduler detail: insert_priority dir: in value: 1
The only other place I found that runs a priority scheduler is here in
nano::active_transactions::activate_successors