Ledger query simplification #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
reviewed
Mar 6, 2024
pwojcikdev
reviewed
Mar 6, 2024
pwojcikdev
reviewed
Mar 6, 2024
pwojcikdev
reviewed
Mar 6, 2024
pwojcikdev
reviewed
Mar 6, 2024
clemahieu
force-pushed
the
ledger_query_simplification
branch
3 times, most recently
from
66bffe2
to
13972dc
Compare
clemahieu
commented
Mar 6, 2024
…single function returning an optional value. This simplifies the ledger interface and uses safer std::optional to signal no value rather than a sentinel 0 value.
…if the previous hash is zero. This removes a dependency on the behaviour of ledger::balance to return a sentinel value of 0 if the block hash cannot be found.
… as an std::optional.
…e to std::optional
clemahieu
force-pushed
the
ledger_query_simplification
branch
from
13972dc
to
2810e4c
Compare
pwojcikdev
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the ledger::account/balance/amount variants in to a single function for each, returning an optional associated value.
The major advantage is a simplification in the nano::ledger interface and increased type-checking in values returned. Previously there were separate functions for assumed-correct function calls protected with debug_assert, and variants permitted to fail that returned error codes or sentinel values.
These changes replace each account/amount/balance with functions that return std::optional values for each associated type. Variants that used assumed-correct functions simply call std::optional::value, which does runtime value checking which increases correctness safety. Variants that used _safe variants or checked sentinel values are replaced with std::optional bool conversion checks and operate the same way.