RPC endpoint for election statistics #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems useful. The PR should include a test that at least runs the code. |
RickiNano
force-pushed
the
aec-statistics
branch
from
dd07e26
to
287c500
Compare
pwojcikdev
reviewed
Apr 3, 2024
| ASSERT_EQ ("0", response1.get<std::string> ("hinted")); | ||
| ASSERT_EQ ("0", response1.get<std::string> ("optimistic")); | ||
| ASSERT_EQ ("0", response1.get<std::string> ("total")); | ||
| ASSERT_EQ ("0.00", response1.get<std::string> ("aec_utilization_percentage")); |
There was a problem hiding this comment.
This could at least start a single election which would ensure reported values work as expected
There was a problem hiding this comment.
@pwojcikdev I'm not sure how to do this. If I start a normal election it might get confirmed before the RPC request is executed.
RickiNano
added a commit
to RickiNano/nano-node
that referenced
this pull request
Apr 5, 2024
qwahzi
added
documentation
RickiNano
added a commit
to RickiNano/nano-node
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new election_statistics RPC endpoint to help identify bottlenecks within the AEC.
The endpoint will respond with the number of active elections for each electiontype. It will also return the percentage of AEC slots in use.
If this is merged, I intend to expand the dataset with the average and max election age.
Request:
Response example: