Move write database queue #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
move_write_database_queue
branch
from
86e5198
to
dc6da93
Compare
pwojcikdev
reviewed
Apr 4, 2024
pwojcikdev
reviewed
Apr 4, 2024
pwojcikdev
previously approved these changes
Apr 4, 2024
…h parent objects.
clemahieu
force-pushed
the
move_write_database_queue
branch
from
66df593
to
fe4d47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames write_database_queue to write_queue and moves the class into the nano::store library. It also moves the object from nano::node to nano::store::component.
This is a more natural place for this class/object to be placed and also preps for confirming_set to be moved on to the ledger class which would otherwise have a cyclic dependency secure -> store -> node -> secure