Fix unit test bootstrap_processor.lazy_pruning_missing_block #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
added
unit test
pwojcikdev
reviewed
Apr 18, 2024
pwojcikdev
reviewed
Apr 22, 2024
nano/secure/ledger.hpp
Outdated
| @@ -116,6 +116,8 @@ class ledger final | |||
| // Returns the next receivable entry equal or greater than 'key' | |||
| std::optional<std::pair<nano::pending_key, nano::pending_info>> receivable_lower_bound (secure::transaction const & tx, nano::account const & account, nano::block_hash const & hash) const; | |||
| void initialize (nano::generate_cache_flags const &); | |||
|
|
|||
| public: // for unit tests only | |||
There was a problem hiding this comment.
This is mainly used by confirming set, so the comment is inaccurate.
There was a problem hiding this comment.
I mean making the member function public for use in unit tests only.
I will make it more explicit.
There was a problem hiding this comment.
This is still less than ideal. A safe pattern similar to the way it's done in other classes should be used that provides a public force_confirm method with a proper release_assert that guards it.
There was a problem hiding this comment.
Let's follow good patterns that are already established and work. A single assert is more descriptive than any comment.
pwojcikdev
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.