Use coroutines in tcp listener #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
previously approved these changes
Apr 23, 2024
nano/lib/async.hpp
Outdated
|
|
||
| /** | ||
| * A cancellation signal that can be emitted from any thread. | ||
| * I follows the same semantics as asio::cancellation_signal. |
clemahieu
reviewed
Apr 23, 2024
| acceptor.listen (asio::socket_base::max_listen_connections); | ||
|
|
||
| { | ||
| std::lock_guard<nano::mutex> lock{ mutex }; | ||
| local = acceptor.local_endpoint (); |
There was a problem hiding this comment.
Does this need to be strand protected?
There was a problem hiding this comment.
Up to this point (including local_endpoint call) all operations are synchronous, so there should be no need to wrap it in a strand. It would be necessary if it was called after main loop is started, that's why it's cached beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix remaining TSAN issues this PR changes tcp listener implementation to use coroutines with a strand. The resulting code is structurally almost identical to the threaded version.
Continuation of #4523