Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum utils #4601

Merged
merged 13 commits into from
May 7, 2024
Merged

Enum utils #4601

merged 13 commits into from
May 7, 2024

Conversation

pwojcikdev
Copy link
Contributor

This organizes enum conversion functions and adds additional checks. This avoids unnecessary boilerplate code.

clemahieu
clemahieu approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@clemahieu clemahieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to have enum_util.hpp as its own header.

@pwojcikdev pwojcikdev merged commit 881adfd into nanocurrency:develop May 7, 2024
25 of 26 checks passed
@pwojcikdev pwojcikdev deleted the enum-utils branch May 7, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwojcikdev @clemahieu