Introduce active_transactions_config

[gr0vity-dev]

Introduce active_transactions_config :

Old config	New config
active_elections_size	active_transactions.size
active_elections_hinted_limit_percentage	active_transactions.hinted_limit_percentage
active_elections_optimistic_limit_percentage	active_transactions.optimistic_limit_percentage
confirmation_history_size	active_transactions.confirmation_history_size
/	active_transactions.confirmation_cache

Newly introduced confirmation_cache is used in recently_confirmed{ config.confirmation_cache }, instead of the hardcoded value 65536

[pwojcikdev]

Nice cleanup. The question is whether we want to call this config [nano.active_transactions] to keep consistency with class naming (transaction name is a bit unfortunate in my opinion) or [nano.active_elections] to keep consistency with previous config naming.

[gr0vity-dev]

I asked myself the same question.
Since the config also includes something unrelated like confirmation_history_size I opted to keep keep consistency with class naming rather than previous naming. (It's a breaking change either way)
Maybe we should name the entire class active_elections because it's basically a container for all ongoing elections ?

[pwojcikdev]

Renaming the class to active_elections sounds better and should be quite easy.

[gr0vity-dev]

I renamed active_transactions to active_elections.
So the update config looks like this :

Old config	New config
active_elections_size	active_elections.size
active_elections_hinted_limit_percentage	active_elections.hinted_limit_percentage
active_elections_optimistic_limit_percentage	active_elections.optimistic_limit_percentage
confirmation_history_size	active_elections.confirmation_history_size
/	active_elections.confirmation_cache

And it can be used in the config-node.toml like this:

[node.active_elections]
    size = 5000
    hinted_limit_percentage = 20
    optimistic_limit_percentage = 10
    confirmation_history_size = 2048
    confirmation_cache = 65536

[clemahieu]

LGTM. Nice cleanup and agree on the class rename.