Directly confirm blocks within unit tests rather than starting/forcing elections #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
added
unit test
clemahieu
force-pushed
the
testing_direct_confirmation
branch
2 times, most recently
from
1205538
to
ab9f963
Compare
…orcing an election. Tests wanting to test election behaviour directly can start their own elections. Though this doesn't fix any specific test problem, this change should be friendly to reducing intermittent test failure due to object interaction effects of running actual network elections.
Tests modified: active_transactions.confirm_frontier active_transactions.keep_local bootstrap_processor.lazy_hash_pruning bootstrap_processor.lazy_hash_pruning frontier_req.confirmed_frontier election.continuous_voting node.vote_by_hash_bundle node.epoch_conflict_confirm node.rollback_vote_self optimistic_scheduler.activate_one optimistic_scheduler.under_gap_threshold rpc.receivable_unconfirmed rpc.history_pruning rpc.accounts_receivable_confirmed rpc.block_confirmed node.aggressive_flooding
clemahieu
force-pushed
the
testing_direct_confirmation
branch
from
ab9f963
to
4c813b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces nano::test::force_confirm with nano::test::confirm and overrides. The action was renamed to test::confirm because the action is to confirm. election::force_confirm is an action specific to an election where the normal path causes confirmation after the vote tally has quorum and force_confirm simulates this.
This removes ledger::force_confirm as it was inappropriately calling the private ledger::confirm(block) rather than the public ledger::confirm(hash).
While this doesn't fix any test specifically it should help with general unit test reliability by not running election functionality when setting up tests.