Remove active_elections::trim #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value was never changed from default.
pwojcikdev
previously approved these changes
May 10, 2024
Each scheduler checks its own limits with calls to active_elections::vacancy. Trim is problematic as it indiscriminately cancels elections without consideration to why it was scheduled or its priority.
clemahieu
force-pushed
the
remove_active_elections_trim
branch
from
fd65cd9
to
53589b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the active_elections::trim function which is problematic with more advanced scheduler logic.
The code is not hit during normal operation because each scheduler already checks its own internal limits before starting elections.