Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use channel as telemetry data key #4697

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

pwojcikdev
Copy link
Contributor

This fixes a problem where telemetry data from a single peer would be duplicated, one under ephemeral and the other under peering port, like this:

(thanks to @gr0vity-dev for noticing this problem)

{
    "metrics": [
      {
        "block_count": "300014",
        "cemented_count": "300014",
        "unchecked_count": "0",
        "account_count": "100006",
        "bandwidth_cap": "10485760",
        "peer_count": "4",
        "protocol_version": "21",
        "uptime": "180",
        "genesis_block": "E670DF81878460B76B3425EC399800E1219A4387B11A4841B16CE260A9F36917",
        "major_version": "28",
        "minor_version": "0",
        "patch_version": "0",
        "pre_release_version": "99",
        "maker": "0",
        "timestamp": "1723035548025",
        "active_difficulty": "000000000000000f",
        "node_id": "node_1wp7kh4cmz5adwwh8b6rujrh48kp8gaijjf1hadgsrpa3assj6uio8p66oj1",
        "signature": "89EC509E21A1CC3EBF970D57D520BE0420EC4B61E0AB00E12100EA1103C92B6A498C2D8BFD1357680F8000539CFD6C2C6EFD7209614BC01B70603A6C757FD508",
        "address": "::ffff:172.19.0.3",
        "port": "17075"
      },
...
      {
        "block_count": "300014",
        "cemented_count": "300014",
        "unchecked_count": "0",
        "account_count": "100006",
        "bandwidth_cap": "10485760",
        "peer_count": "4",
        "protocol_version": "21",
        "uptime": "240",
        "genesis_block": "E670DF81878460B76B3425EC399800E1219A4387B11A4841B16CE260A9F36917",
        "major_version": "28",
        "minor_version": "0",
        "patch_version": "0",
        "pre_release_version": "99",
        "maker": "0",
        "timestamp": "1723035608284",
        "active_difficulty": "000000000000000f",
        "node_id": "node_1wp7kh4cmz5adwwh8b6rujrh48kp8gaijjf1hadgsrpa3assj6uio8p66oj1",
        "signature": "F8F2E9337BD94C72A9F6482390D87912993E679E9D4848DE734C358134A1CB0122EE768BCFA1267F926B08354197A7A450F5AEC2FF727D8B822B5775043AEB0A",
        "address": "::ffff:172.19.0.3",
        "port": "35816"
      }

@qwahzi qwahzi added this to the V28 milestone Sep 25, 2024
@pwojcikdev pwojcikdev merged commit 885447f into nanocurrency:develop Oct 15, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

2 participants