Database scan improvements #4734
Merged
+239
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both RocksDB test cases show significant improvement:
|
Merged
clemahieu
previously approved these changes
Sep 28, 2024
| { | ||
| pending_iterator.next (transaction); | ||
| if (!(*pending_iterator).is_zero ()) | ||
| // TODO: This pending iteration heuristic should be encapsulated in a pending_iterator class and reused across other components |
There was a problem hiding this comment.
Is this heuristic used to skip accounts with a large number of pending entries? A comment on why using sequential scanning alone is insufficient would help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses iterators for fetching accounts for ascending bootstrap database scan. This significantly reduces the load on the database backend in case of RocksDB.