Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate cemented blocks #4757

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

pwojcikdev
Copy link
Contributor

@pwojcikdev pwojcikdev commented Oct 18, 2024

This makes a few adjustments to the way active elections are handled that I believe should be changed.

First, it activates accounts whenever a block is cemented, either directly via election or indirectly via confirmation height. Previously activations were performed only for blocks that were part of an active election, which I believe can lead to some accounts not being prioritized properly (missed activation = long confirmation time for legit blocks).

Second, it adjusts how cemented blocks are handled in active election container. The handling is modified, so that it all happens under exclusive lock (prevents new election insertions while cemented blocks are processed), which is a step towards making interaction of cementing_set <-> active_elections components simpler to reason about.

@gr0vity-dev-bot
Copy link

gr0vity-dev-bot commented Oct 18, 2024

Test Results for Commit 82d9d2d

Pull Request 4757: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 112s)
  • 5n4pr_conf_10k_change: PASS (Duration: 221s)
  • 5n4pr_conf_change_dependant: PASS (Duration: 162s)
  • 5n4pr_conf_change_independant: PASS (Duration: 154s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 133s)
  • 5n4pr_conf_send_independant: PASS (Duration: 138s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 118s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 229s)

Last updated: 2024-10-18 14:59:45 UTC

@pwojcikdev pwojcikdev merged commit 0b6a5cc into nanocurrency:develop Oct 18, 2024
28 checks passed
@qwahzi qwahzi added this to the V28 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

4 participants