Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #1

Merged
merged 11 commits into from
Oct 27, 2021
Merged

Initial commit #1

merged 11 commits into from
Oct 27, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Add repo and pipeline config.
  • Add initial version migrated from nanoFramework/Windows.Devices.Adc

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Laurent Ellerbach <laurelle@microsoft.com>
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments before approving

@josesimoes josesimoes requested a review from Ellerbach October 27, 2021 15:46
@josesimoes josesimoes requested a review from Ellerbach October 27, 2021 16:01
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@josesimoes josesimoes requested a review from Ellerbach October 27, 2021 16:07
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@josesimoes josesimoes merged commit 4403f46 into nanoframework:develop Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants