Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Io.Directory class #17

Merged
merged 13 commits into from
Apr 22, 2021

Conversation

morali
Copy link
Contributor

@morali morali commented Apr 16, 2021

Description

Added Directory class to System.IO.FileSystem library. Directory class API is based on Microsoft one.

Motivation and Context

In order to get rid of two different APIs needed for access to SD Card, I created simple Directory class. It allows for folder manipulation on SD card. For now this API simply calls native firmware methods. It could be used as a starter for developing full featured Directory class.

I am open to any suggestions, as i don't have much experience with developing C# libraries.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Care to add the Intellisense comments for completeness?

@josesimoes josesimoes marked this pull request as draft April 18, 2021 13:01
@morali
Copy link
Contributor Author

morali commented Apr 19, 2021

Looking good!

Care to add the Intellisense comments for completeness?

Yes of course. Intellisense comments has been added.

@morali morali changed the title WIP: System io directory class System io directory class Apr 21, 2021
@morali morali marked this pull request as ready for review April 21, 2021 11:03
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title System io directory class Add System.Io.Directory class Apr 22, 2021
@josesimoes josesimoes merged commit 6b4894e into nanoframework:develop Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants