Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop initial version #2

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Develop initial version #2

merged 6 commits into from
Dec 11, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Initial version.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

NiciAndres and others added 6 commits September 28, 2020 18:08
@NiciAndres
***WIP*** Add library solution (#1)
fb5c320 
This is a **WIP**

- Issues with stubs and CMake generation.
- Pending code review to conform with code style.

***NO_CI***
@josesimoes
Fix nf properties in project file
655c667
@josesimoes
Clean-up assembly info
10e13fb
@josesimoes
Add license headers
d860858 
- Also removed unsed usings.
@josesimoes
Code review & refactoring
e4429ef 
- Move native calls declaration to inside the using class.
- Rework code based on code style.
- Rework code on code review.
- Fix typos.
- Add sonarcloud rule exclusions.
@josesimoes
Work CI-CD
c469444 
- Update nuspec.
- Add logo and rename license.
- Update mscorlib NuGet.
- Add nbgv package and build.
@josesimoes josesimoes merged commit 0b4543a into develop Dec 11, 2020
@josesimoes josesimoes deleted the develop-initial-version branch December 11, 2020 19:30
@josesimoes
Copy link
Member Author

@nfbot updatedependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @NiciAndres