GetDirectoryName fixed for path with no slash #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed the bug, when the -1 returned from method LastIndexOf() was a second parameter of method Substring, which obviosuly gave an error.
Motivation and Context
I have checked the proposed change of behaviour with original C# and it seems to work as I propose.
Please check my snippet here: https://dotnetfiddle.net/ZuRy2E
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
By the way:
Link https://github.com/nanoframework/.github/blob/main/CONTRIBUTING.md is not working for me (firefox).