Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetDirectoryName fixed for path with no slash #32

Conversation

dgGC5
Copy link
Contributor

@dgGC5 dgGC5 commented Jun 28, 2021

Description

I have fixed the bug, when the -1 returned from method LastIndexOf() was a second parameter of method Substring, which obviosuly gave an error.

Motivation and Context

I have checked the proposed change of behaviour with original C# and it seems to work as I propose.
Please check my snippet here: https://dotnetfiddle.net/ZuRy2E

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

By the way:
Link https://github.com/nanoframework/.github/blob/main/CONTRIBUTING.md is not working for me (firefox).

@nfbot nfbot added the Type: Bug Something isn't working label Jun 28, 2021
@dnfadmin
Copy link

dnfadmin commented Jun 28, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit de67138 into nanoframework:develop Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants