Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace event category with new HighResolutionTimer #147

Conversation

Henrik98
Copy link
Contributor

@Henrik98 Henrik98 commented Oct 19, 2021

Description

  • Replace event category with new HighResolutionTimer.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Henrik <zhenkol@gmail.com>
@nfbot nfbot added the Type: bug Something isn't working label Oct 19, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes changed the title EventCategory.Custom -> EventCategory.HighResolutionTimer Replace event category with new HighResolutionTimer Oct 19, 2021
@nfbot nfbot added Type: enhancement New feature or request Breaking-Change labels Oct 19, 2021
@josesimoes josesimoes added Breaking-Change and removed Type: bug Something isn't working Breaking-Change labels Oct 19, 2021
@josesimoes
Copy link
Member

  • Edited the title and completed the description.
  • Changed the change list.
  • Since the issue it's referring it's on another repo you have to use the full "path". Just use what's in the template. It's there to help. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes enabled auto-merge (squash) October 19, 2021 11:54
@josesimoes josesimoes merged commit 5aa337b into nanoframework:develop Oct 20, 2021
@nfbot
Copy link
Member

nfbot commented Oct 20, 2021

@Henrik98 thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/Henrik98.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/Henrik98"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

@Henrik98 Henrik98 deleted the issue_846_Esp32_HighResEventListener_wrongly_uses_EventCategory_Custom branch October 20, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Esp32.HighResEventListener wrongly uses EventCategory.Custom
4 participants