Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in grammar and Intellisense comments #164

Merged
merged 9 commits into from
Jun 15, 2022
Merged

Various fixes in grammar and Intellisense comments #164

merged 9 commits into from
Jun 15, 2022

Conversation

MichaelWheeley
Copy link
Contributor

@MichaelWheeley MichaelWheeley commented Jun 15, 2022

Description

Updated ESP32.Sleep documentation to clarify documentation missing, grammatically incorrect, or spelling corrections.

Motivation and Context

  • Fixes nanoFramework.Hardware.Esp32

How Has This Been Tested?

There are no code changes to test, only documentation.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW!!! Awesome and very much welcome fixes!! 💯 😅

MichaelWheeley and others added 7 commits June 15, 2022 14:59
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes
Copy link
Member

@MichaelWheeley seems that one of your commits it's signed with a different github user and the CLA bot it's asking for a new signature...

@MichaelWheeley
Copy link
Contributor Author

@MichaelWheeley and @michael R Wheeley are apparently two different people, I'll let him know ;-)

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks.

@josesimoes josesimoes changed the title Wheeley/esp32 sleep grammar and docs Various fixes in grammar and Intellisense comments Jun 15, 2022
@josesimoes josesimoes merged commit e134ece into nanoframework:main Jun 15, 2022
@MichaelWheeley MichaelWheeley deleted the wheeley/ESP32SleepGrammar branch June 15, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants