Allow ESP32 boards to work with Visual studio extension #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the check for "STM32 STLINK" com port name. Found that sometimes when connecting boards receieved a Device error which was causing a NotImplemented Exception and stopped.
On some boards it defaults to 7 data bits Signed-off-by: Adrian Soundy <adriabsoundy@gmail.com>
|
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
|
josesimoes
requested changes
Dec 29, 2017
| // the default on the current ST Link is different causing | ||
| // the communication to fail | ||
| ///////////////////////////////////////////////////////////// | ||
| _device.DataBits = 8; |
There was a problem hiding this comment.
Please add back the comment block that was there. It seems harmless but it has cost a lot of time finding the root cause for the issue and that comment documents that. 😉
| // the default on the current ST Link is different causing | ||
| // the communication to fail | ||
| ///////////////////////////////////////////////////////////// | ||
| _device.DataBits = 8; |
There was a problem hiding this comment.
Please add back the comment block that was there. It seems harmless but it has cost a lot of time finding the root cause for the issue and that comment documents that. 😉
Also found another place where device is set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow ESP32 boards to work with Visual Studio extension
Description
The original code only allowed serial ports with the name "STM32 ST LINK" to connect, this change removes this check.
With the ESP32 boards the serial link would default to 7 bit data but 8 bit data is required. Now it is forced to 8 bit data.
Motivation and Context
How Has This Been Tested?
Now when an ESP32 board is connected it is seen in Visual Studio.
Screenshots
Types of changes
Checklist:
Signed-off-by: Adrian Soundy adriabsoundy@gmail.com