Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with wireless config save/load #135

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

josesimoes
Copy link
Member

Description

  • The string fields weren't being properly handled
  • Add constructors to config base classes to ensure that the byte arrays size match
  • Minor improvements in WPF test app

Motivation and Context

  • Fixes issue with storing/getting wireless config block to/from device

How Has This Been Tested?

  • WPF test app

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

- The string fields weren't being properly handled
- Add constructors to config base classes to ensure that the byte arrays size match
- Minor improvements in WPF test app

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Apr 19, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 496e730 into nanoframework:develop Apr 19, 2018
@josesimoes josesimoes deleted the fix-wireless-config branch April 19, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants