Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugging_Execution_BreakpointDef #144

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Need to change type and constant declaration to match native execution

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Need to change type and constant declaration to match native execution

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jun 7, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit fd30889 into nanoframework:develop Jun 7, 2018
@josesimoes josesimoes deleted the fix-BreakpointDef-types branch June 7, 2018 09:45
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 7, 2018
- Need to change type and constant declaration because of comparisons with thread process ID
- Required to support nanoframework/nf-debugger#144

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants