Improvements in engine process exit and termination #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove EngineState as we dont't need that anymore: incomming messages are handled on a Task - Rework Debugger.Engine accordingly - Replace checks related with EngineState with ones using _backgroundProcessor Task - Improve code related with calls to ProcessExit on device failure Signed-off-by: José Simões <jose.simoes@eclo.solutions>
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added a commit
that referenced
this pull request
Jun 8, 2018
This reverts commit 0743675.
josesimoes
added a commit
that referenced
this pull request
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions