Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in engine process exit and termination #147

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add check for engin running on engine connectasync
  • Improve code related with calls to ProcessExit on device failure
  • Improve code in engine IncomingMessagesListenerAsync
  • Engine is not stoped anymore on SeriaPort device disconect
  • Add missing exception in UsbDevice
  • Update WPF test app

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Add check for engin running on engine connectasync
- Improve code related with calls to ProcessExit on device failure
- Improve code in engine IncomingMessagesListenerAsync
- Engine is not stoped anymore on SeriaPort device disconect
- Add missing exception in UsbDevice
- Update WPF test app

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jun 8, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 8c2dee3 into nanoframework:develop Jun 8, 2018
@josesimoes josesimoes deleted the improvements-process-exit branch June 8, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants