Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements device discovery and PortBase classes #182

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Improve check of nanoBooter on device discovery: the code now checks for a valid marker in the received packet.
  • PortBase class now has methods to Start and stop the device watchers and also to rescan devices.
  • SerialPort and UsbPort now have an overloaded constructor allowing to instanciate the class without starting the device watchers.
  • Update test app.

Motivation and Context

  • Improves device discovery.
  • Improves developer experience allowing VS to start debugger component with or without device watchers started.
  • Improves developer experience allowing VS to rescan devices without forcing developer to physically unplug and plug nanoDevices that are behind a serial converter.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- The code now checks for a valid marker in the received packet

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- PortBase class now has methods to Start and stop the device watchers and also to rescan devices.
- SerialPort and UsbPort now have an overloaded constructor allowing to instanciate the class without starting the device watchers.
- Update test app.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Feb 11, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1e71c48 into nanoframework:develop Feb 11, 2019
@josesimoes josesimoes deleted the improvements-device-discovery branch February 11, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants