Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on ReadMemory command #195

Merged
merged 1 commit into from
May 29, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add ErrorCode field to Monitor_ReadMemory.Reply class.
  • Update deserializer method accordingly.
  • Add enum with error codes for access memory operations.
  • Rework Engine.ReadMemory() methods to add operation error code.
  • Rework Engine.ReadMemory() method to improve processing of reply.
  • Update test app to verify command functionality.

Motivation and Context

  • ReadMemory command wasn't working properly.
  • Needed the command to be able to read BOOTLOADER and CLR regions to improve VS extension features.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Add ErrorCode field to Monitor_ReadMemory.Reply class.
- Update deserializer method accordingly.
- Add enum with error codes for access memory operations.
- Rework Engine.ReadMemory() methods to add operation error code.
- Rework Engine.ReadMemory() method to improve processing of reply.
- Update test app to verify command funcionality.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented May 29, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1824e46 into nanoframework:develop May 29, 2019
@josesimoes josesimoes deleted the work-read-memory-cmd branch May 29, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants