Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework COM port black list #247

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Rework COM port black list #247

merged 1 commit into from
Jul 24, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Rename to Port black list to be more generic (instead of COM port specific).
  • Move property to PortBase.
  • Update code accordingly.
  • Bump version to 1.18.0-preview.

Motivation and Context

  • Improves usability and makes it more generic.

How Has This Been Tested?

  • WPF test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Jul 24, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Rework COM port black list
d981cee 
- Rename to Port black list to be more generic (instead of COM port specific).
- Move property to PortBase.
- Update code accordingly.
@josesimoes josesimoes merged commit a9f591b into nanoframework:develop Jul 24, 2020
@josesimoes josesimoes deleted the fix-port-list branch July 24, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-Change CI: Publish Release CI: Update Dependents Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot