Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on capability flags #253

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Move HasProprietaryBooter and IFUCapable flags to Ping.
  • Add ConfigBlockRequiresErase to ping because this information is also required when running booter and it wasn't available there.
  • Rename Ping flags field to drop "debug" hit on the name.
  • Rename Ping source field to follow code style guidelines.

Motivation and Context

  • These capability flags are needed on both booter and CLR so they need to be moved to a command that is present on both.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Move HasProprietaryBooter and IFUCapable flags to ping (they are needed on both booter and CLR).
- Add ConfigBlockRequiresErase to ping because this information is also required when running booter and it wasn't available there.
- Rename Ping flags field to drop "debug" hit on the name.
- Rename Ping source field to follow code style guidelines.
@nfbot
Copy link
Member

nfbot commented Nov 6, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 717f211 into nanoframework:develop Nov 6, 2020
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Following nanoframework/nf-debugger#253.
@josesimoes josesimoes deleted the work-flags branch November 6, 2020 17:36
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 6, 2020
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants