Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attempts parameter to ConnectAsync #280

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 27, 2020

Description

  • Add Polly wait and retry policy to perform repeated attempts to connect to a device.

Motivation and Context

  • Improve operation robustness and resilience to failure by taking the responsibility to retry the operation, instead of being the client app.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nanoframework nanoframework deleted a comment from nfbot Nov 27, 2020
@josesimoes josesimoes force-pushed the improve-connect branch 4 times, most recently from c1b6fb2 to c1a7908 Compare November 27, 2020 09:50
- Add Polly wait and retry policy to perform repeated attempts to connect to a device.
- Rebuild packages.lock for UWP project.
@josesimoes josesimoes merged commit c8abd72 into nanoframework:develop Nov 27, 2020
@josesimoes josesimoes deleted the improve-connect branch November 27, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants