Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set execution #311

Merged
merged 2 commits into from
May 27, 2021
Merged

Fix set execution #311

merged 2 commits into from
May 27, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Return now depends on the operation success.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Improve handling of WP request execution
fc4a84e 
- Idle check is now decreased to 50ms.
- Add code to prevent a request from waiting forever for the controller to be idle.
- Request time stamp is now added even for failed requests, thus allowing the request to be remove from the queue in any event.
@josesimoes
Fix setting debug execution conditions
ba47286 
- Was returning true even if the set operation failed.
@josesimoes josesimoes merged commit ec5b8ab into develop May 27, 2021
@josesimoes josesimoes deleted the fix-set-execution branch May 27, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot