Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements #313

Merged
merged 1 commit into from
May 27, 2021
Merged

General improvements #313

merged 1 commit into from
May 27, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Erase memory doesn't ping device anymore (no need to find if it's responsive).
  • Detection clears buffers to make sure there is nothing preventing a correct communication with the device.
  • No need to force connect on detection.
  • Setting execution flags now has a delay of 500ms before returning to allow the target to settle with the new conditions.

Motivation and Context

  • Improves device detection and communication workflow.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Erase memory doesn't ping device anymore (no need to find if it's responsive).
- Detection clears buffers to make sure there is nothing preventing a correct communication with the device.
- No need to force connect on detection.
- Setting execution flags now has a delay of 500ms before returning to allow the target to settle with the new conditions.
@josesimoes josesimoes merged commit 3b8c347 into develop May 27, 2021
@josesimoes josesimoes deleted the general-improvements branch May 27, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants