Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packet size for targets requiring program alignment #317

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Packet size algorithm was failing to handle packet size smaller than the program aliment size.
  • Change default timeout for write memory to twice the default timeout.

Motivation and Context

  • When buffer size had the last chunk of data smaller than the program alignment size, this ended on a endless loop wrongly sending a zero sized packet to wrap up the operation.
  • For packets of a large size in MCUs that have long flash write times, this could result on timeout errors causing the operation to fail.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Chang default timeout for write memory to twice the default timeout.
@nfbot nfbot added the Type: Bug label Aug 9, 2021
@josesimoes josesimoes merged commit a886ebc into nanoframework:develop Aug 9, 2021
@josesimoes josesimoes deleted the fix-program-aligment branch August 9, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants