Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Linux SerialPort lookup #320

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

bart-jansen
Copy link
Contributor

@bart-jansen bart-jansen commented Sep 24, 2021

Description

Improved Linux SerialPort lookup to have better support for devices connected on /dev/ttyUSB, /dev/ttyACM and /dev/ttyAMA.

Motivation and Context

When trying to enumerate the devices on Raspbian, the device was available under /dev/ttyUSB0 but previously these ports were never scanned because it was only scanning /dev/ttyGS and /dev/ttyS.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 24, 2021

Hi @bart-jansen,

😞 I'm afraid you'll have to use the PR template like the rest of us...
Make sure you've used the template and have include all the required information and fill in the appropriate details. After doing that feel free to reopen the PR. If you have questions we are here to help..

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement and testing all this with various devices!

@Ellerbach
Copy link
Member

@bart-jansen please take care of the SonarCloud code smells, push a fix and we should be good to merge.

@Ellerbach Ellerbach merged commit c1aa213 into nanoframework:develop Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants