Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve write memory operation #334

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Improve parsing of write memory request result.
  • Add tiny sleep between write memory operations to account for failures.
  • Increase timeout for write operation.
  • Add empty flags constant.
  • CheckMemory renamed to PerformWriteMemoryCheck.
  • Write memory operation check is now performed on release build.
  • Fix WPF test app.
  • Bump version to 2.1.0-preview.

Motivation and Context

  • Attempt to improve write memory operations in some devices.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Improve parsing of write memory request result.
- Add tiny sleep between write memory operations to account for failures.
- Increase timeout for write operation.
- Add empty flags constant.
- CheckMemory renamed to PerformWriteMemoryCheck.
- Write memory operation check is now performed on release build.
- Fix WPF test app.
- Bump version to 2.1.0-preview.
@josesimoes josesimoes merged commit 5fcb85a into nanoframework:develop Dec 2, 2021
@josesimoes josesimoes deleted the improve-write-memory branch December 2, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants