Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct WriteMemoryAsync #56

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

josesimoes
Copy link
Member

Description

  • Add extra code to always transmit data packets with at least 64 bytes.
    +semver: fix

Motivation and Context

  • Resolves major issue of not being able to deploy an app when the assembly blob size had the last packet shorter than 64 bytes.

How Has This Been Tested?

  • Deployment successful for various apps in VS experimental instance.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Add extra code to always transmit data packets with at least 64 bytes.
+semver: fix

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Oct 17, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 13d4f76 into nanoframework:develop Oct 18, 2017
@josesimoes josesimoes deleted the correct-write-memory branch October 18, 2017 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants