Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding System.IO.Ports support #1921

Merged
merged 18 commits into from
May 24, 2021
Merged

Adding System.IO.Ports support #1921

merged 18 commits into from
May 24, 2021

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented May 20, 2021

Description

  • Add assembly declaration.
  • Update CMakes accordingly.
  • Add implementation for all platforms.

Motivation and Context

How Has This Been Tested?

  • Full tests running on an ESP32.
  • ChibiOS images building.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented May 20, 2021

@Ellerbach there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #1922, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@nfbot
Copy link
Member

nfbot commented May 20, 2021

@Ellerbach there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #1923, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@josesimoes josesimoes closed this May 24, 2021
@josesimoes josesimoes deleted the develop-serialport branch May 24, 2021 18:16
@josesimoes josesimoes restored the develop-serialport branch May 24, 2021 18:17
@josesimoes josesimoes reopened this May 24, 2021
@josesimoes josesimoes added Area: Common libs Everything related with common libraries Breaking-change Type: enhancement and removed invalid labels May 24, 2021
@josesimoes josesimoes force-pushed the develop-serialport branch from 22a52fb to eaf4d6b Compare May 24, 2021 18:18
@nfbot
Copy link
Member

nfbot commented May 24, 2021

@Ellerbach there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #1932, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@nanoframework nanoframework deleted a comment from nfbot May 24, 2021
@nanoframework nanoframework deleted a comment from nfbot May 24, 2021
@nanoframework nanoframework deleted a comment from nfbot May 24, 2021
@nanoframework nanoframework deleted a comment from nfbot May 24, 2021
nfbot added 2 commits May 24, 2021 19:26
Automated fixes for code style.
Automated fixes for code style.
@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label May 24, 2021
@josesimoes josesimoes removed Breaking-change Type: dependencies Pull requests that update a dependency file(s) or version labels May 24, 2021
@josesimoes josesimoes merged commit b8be700 into develop May 24, 2021
@josesimoes josesimoes deleted the develop-serialport branch May 24, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants