Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs (Windows.Devices) #2283

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Apr 19, 2022

Description

  • Remove all Windows.Devices implementations.
  • Adjust CMakes accordingly.
  • Move code to corresponding Sys.Devices when needed.
  • Remove respective target config files.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform Platform: ESP32 Everything related specifically with ESP32 platform Platform: NXP Everything related specifically with FreeRTOS Platform: TI-SimpleLink labels Apr 19, 2022
@josesimoes josesimoes force-pushed the remove-deprecated-apis branch from 5b530ef to 9f33c6f Compare April 19, 2022 11:13
- Remove all Windows.Devices implementations.
- Adjust CMakes accordingly.
- Move code to corresponding Sys.Devices when needed.
- Remove respective target config files.
@josesimoes josesimoes force-pushed the remove-deprecated-apis branch from 9f33c6f to 5811970 Compare April 19, 2022 11:27
@josesimoes josesimoes merged commit c736803 into nanoframework:main Apr 19, 2022
@josesimoes josesimoes changed the title Remove deprecated APIs Remove deprecated APIs (Windows.Devices) Apr 19, 2022
@josesimoes josesimoes deleted the remove-deprecated-apis branch April 19, 2022 11:47
josesimoes added a commit to josesimoes/nf-interpreter that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Config-and-Build Breaking-change Platform: ESP32 Everything related specifically with ESP32 platform Platform: NXP Everything related specifically with FreeRTOS Platform: STM32 Everything related specifically with ChibiOS platform Platform: TI-SimpleLink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate/drop Windows.Devices namespace in favour of System.Device
2 participants