Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 to CI tests #37

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

chimaerase
Copy link
Contributor

@chimaerase chimaerase commented Nov 8, 2022

Adding the newly-released Python version.

I also ran some tests against an updated version of the Dockerfile from #31 using Python 3.11 and was able to do gaussian tests similar to #30 in the new version.

@jellis18 jellis18 self-requested a review November 8, 2022 11:18
Copy link
Collaborator

@jellis18 jellis18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the python version badge in README and add python 3.11 to setup.py as well?

@chimaerase
Copy link
Contributor Author

Can you update the python version badge in README and add python 3.11 to setup.py as well?

Great catch, thanks! I am mostly working on closed-source Python application code, so these aren't often on my radar.

@jellis18
Copy link
Collaborator

There was a problem with the flake8 pre-commit. If you merge in master and the tests should pass.

Adding the newly-released Python version.
@chimaerase
Copy link
Contributor Author

chimaerase commented Nov 16, 2022

There was a problem with the flake8 pre-commit. If you merge in master and the tests should pass.

Force pushing to rebase this branch onto master (the merge was completely automated -- no conflicts)

@jellis18 jellis18 merged commit 3d7c198 into nanograv:master Nov 16, 2022
@chimaerase chimaerase deleted the add-python-3.11-to-CI branch November 30, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants