-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for index arrays in ShermanMorrison #356
Allow for index arrays in ShermanMorrison #356
Conversation
…OAs for EcorrKernelNoise signals
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #356 +/- ##
==========================================
+ Coverage 88.35% 88.42% +0.07%
==========================================
Files 13 13
Lines 3023 3033 +10
==========================================
+ Hits 2671 2682 +11
+ Misses 352 351 -1
Continue to review full report in Codecov by Sentry.
|
…ices' into quant2ind_returns_indices
@AaronDJohnson, unit tests for the extra lines are done. As commented on the code, the remaining two lines that aren't covered have never been covered and IMHO shouldn't even exist. I vote to leave those like this |
This one solves #319 by allowing
EcorrKernelNoise
to work with index arrays, rather than slice objects. The function that is changed now isquant2ind
, which now by default returns an list of index arrays.The
fastshermanmorrison
package with Cython code is also compatible with this change, in case anyone is using that. Just upgrade it with pipThanks to Bjorn Larsen for providing a first outline of this modification.
TODO:
_setup_sparse
and_get_ndiag_sparse
inEcorrKernelNoise
to allow for index arraysEcorrKernelNoise
Depends on #352 for codev report