-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched test_orf to nside=16 to decrease memory footprint #404
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #404 +/- ##
==========================================
+ Coverage 85.36% 87.66% +2.30%
==========================================
Files 13 13
Lines 3163 3163
==========================================
+ Hits 2700 2773 +73
+ Misses 463 390 -73 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Alright, I guess that doesn't work :/ |
Alright, I'm a little lost now. It succeeds for macos-13 python3.8, but it fails for the other macos-python versions |
@vhaasteren is the Cython version different for 3.8? It was either this Cython or Numpy 2 update that caused the whole issue in the first place, as far as I can tell. |
Ah, now there's something! Good catch. The macos py3.8 version lists:
And the macos py3.9 version says:
So the latter one uses numpy-2.02. You are right, that could be it |
This decreases the memory footprint of
test_orf
so that github actions may run on it.