Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched test_orf to nside=16 to decrease memory footprint #404

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

vhaasteren
Copy link
Member

This decreases the memory footprint of test_orf so that github actions may run on it.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (ae7521e) to head (6fa2bdd).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #404      +/-   ##
==========================================
+ Coverage   85.36%   87.66%   +2.30%     
==========================================
  Files          13       13              
  Lines        3163     3163              
==========================================
+ Hits         2700     2773      +73     
+ Misses        463      390      -73     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e84f13...6fa2bdd. Read the comment docs.

@vhaasteren
Copy link
Member Author

Alright, I guess that doesn't work :/

@vhaasteren
Copy link
Member Author

Alright, I'm a little lost now. It succeeds for macos-13 python3.8, but it fails for the other macos-python versions

@AaronDJohnson
Copy link
Collaborator

AaronDJohnson commented Dec 10, 2024

@vhaasteren is the Cython version different for 3.8? It was either this Cython or Numpy 2 update that caused the whole issue in the first place, as far as I can tell.

@vhaasteren
Copy link
Member Author

@vhaasteren is the Cython version different for 3.8? It was either this Cython or Numpy 2 update that caused the whole issue in the first place, as far as I can tell.

Ah, now there's something! Good catch. The macos py3.8 version lists:

Collecting numpy>=1.16.3 (from enterprise-pulsar==0.1.dev1+g9af376a)
  Using cached numpy-1.24.4-cp38-cp38-macosx_10_9_x86_64.whl.metadata (5.6 kB)

And the macos py3.9 version says:

  Collecting numpy>=1.16.3 (from enterprise-pulsar==0.1.dev1+g9af376a)
  Using cached numpy-2.0.2-cp39-cp39-macosx_10_9_x86_64.whl.metadata (60 kB)

So the latter one uses numpy-2.02. You are right, that could be it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants