Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows IPC accept cancellation not wired up #1347

Closed
gdamore opened this issue Nov 15, 2020 · 0 comments
Closed

windows IPC accept cancellation not wired up #1347

gdamore opened this issue Nov 15, 2020 · 0 comments
Assignees
@gdamore
Labels
bug
Milestone
v1.5

Comments

@gdamore
Copy link
Contributor

gdamore commented Nov 15, 2020

Looking closely at the Windows IPC code, it appears that we never properly handled cancellation of an accept. It also looks like we never wired nni_aio_schedule().
@gdamore gdamore added the bug label Nov 15, 2020
@gdamore gdamore self-assigned this Nov 15, 2020
@gdamore gdamore added this to the v1.4 milestone Nov 15, 2020
gdamore added a commit that referenced this issue Nov 16, 2020
@gdamore
fixes #1347 windows IPC accept cancellation not wired up
d0944c3
gdamore added a commit that referenced this issue Nov 16, 2020
@gdamore
fixes #1347 windows IPC accept cancellation not wired up
bc78524
@gdamore gdamore modified the milestones: v1.4, v1.5 Jan 25, 2021
@gdamore gdamore closed this as completed in 9f2e4a5 Sep 6, 2021
JaylinYu pushed a commit to nanomq/nng that referenced this issue Oct 2, 2021
@gdamore @JaylinYu
fixes nanomsg#1347 windows IPC accept cancellation not wired up
879dd7f
JaylinYu pushed a commit to nanomq/nng that referenced this issue Oct 2, 2021
@gdamore @JaylinYu
fixes nanomsg#1347 windows IPC accept cancellation not wired up
4e2b9bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
bug
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
1 participant
@gdamore