fixes #1673 High CPU usage with TLS #1725
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aio for connections was meant to have an infinite sleep (no timeout), but was getting an initial value of zero, so we were spinning on accept.
gdamore
force-pushed
the
gdamore/tls-aio
branch
from
a14035c
to
cc58517
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
- Coverage 79.15% 79.12% -0.03%
==========================================
Files 89 89
Lines 20254 20255 +1
==========================================
- Hits 16032 16027 -5
- Misses 4222 4228 +6 ☔ View full report in Codecov by Sentry. |
|
If this passes all the tests, which I expect at this point it will, I'll merge this even though it will close the bug. If the bug isn't actually resolved (I'm pretty sure looking at this it will fix it), then we should reopen it (or open a new one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aio for connections was meant to have an infinite sleep (no timeout), but was getting an initial value of zero, so we were spinning on accept.