Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdamore/no untyped pipe get #1910

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Gdamore/no untyped pipe get #1910

merged 2 commits into from
Nov 3, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 3, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This is a step on the path to removing unsafe untyped option accesses.
The underlying stream APIs have no need for untyped accessors.
Another step on the road to removal of NNI_TYPE_OPAQUE.
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (a5807e4) to head (4367013).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
+ Coverage   80.02%   80.15%   +0.13%     
==========================================
  Files          94       94              
  Lines       24275    24253      -22     
  Branches     3259     3258       -1     
==========================================
+ Hits        19426    19441      +15     
+ Misses       4777     4735      -42     
- Partials       72       77       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 4367013 into main Nov 3, 2024
16 of 17 checks passed
@gdamore gdamore deleted the gdamore/no-untyped-pipe-get branch November 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant