Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX poller: add support for select, and for choosing the poller #1996

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 18, 2024

Some platforms or configurations may not have more modern options like kqueue or epoll, or may be constrained by policy.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Some platforms or configurations may not have more modern options
like kqueue or epoll, or may be constrained by policy.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.99%. Comparing base (d83f5ae) to head (6c949de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/posix/posix_pollq_kqueue.c 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
- Coverage   82.07%   81.99%   -0.08%     
==========================================
  Files          95       95              
  Lines       24033    24033              
  Branches     3167     3167              
==========================================
- Hits        19725    19706      -19     
- Misses       4235     4256      +21     
+ Partials       73       71       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 6c949de into main Dec 18, 2024
18 of 19 checks passed
@gdamore gdamore deleted the test-for-select branch December 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant